Allow nesting in Raised/Flat Buttons #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hai-cea
added a commit
that referenced
this pull request
Feb 11, 2015
Allow nesting in Raised/Flat Buttons
|
Thanks @gabdallah222 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for user to pass down children as opposed to a label to allow for things like creating a material-ui input type='file' and Icon + Text buttons (issue #189). Label or children are required - however, will not accept both. Instead, the children should include the label element or something thereof. This will give the user more control over the button components. Updated docs with examples as well.
It should be noted that in the case of nested elements - the user is responsible for all stylings (ie - all stylings in examples of nested children are not referenced in mui-src. So, if a user wanted to take the input type='file' example, they would want to copy over the stylings in the buttons.less on the docs site.)