Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Cleanup remaining @mui/styles usages #32313

Merged
merged 3 commits into from
Apr 25, 2022

Conversation

mnajdova
Copy link
Member

It's time, let's finish this up. Closes #16947

@mnajdova mnajdova marked this pull request as draft April 15, 2022 08:49
@mui-bot
Copy link

mui-bot commented Apr 15, 2022

No bundle size changes

Generated by 🚫 dangerJS against be9ac58

@mnajdova mnajdova marked this pull request as ready for review April 15, 2022 09:15
@mnajdova mnajdova requested a review from a team April 15, 2022 09:16
@danilo-leal danilo-leal added the docs Improvements or additions to the documentation label Apr 15, 2022
@siriwatknp
Copy link
Member

The virtualized table looks weird.

Screen Shot 2565-04-17 at 22 58 35

@mnajdova
Copy link
Member Author

mnajdova commented Apr 18, 2022

The virtualized table looks weird.

You are right! I was depending on argos to signal if something is wrong with the demos tough, but looks like we are not covering this one. I am on it


Edit: fixed!

@mnajdova mnajdova requested review from a team and removed request for siriwatknp and a team April 21, 2022 06:43
Copy link
Member

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mnajdova mnajdova merged commit 92a4866 into mui:master Apr 25, 2022
@oliviertassinari oliviertassinari added the package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. label May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Replace makeStyles/withStyles with sx prop and styled
6 participants