Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Split install commands in isolated code blocks #32566

Merged
merged 9 commits into from
May 5, 2022
Merged

[docs] Split install commands in isolated code blocks #32566

merged 9 commits into from
May 5, 2022

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented May 3, 2022 •
edited

@danilo-leal danilo-leal added the docs Improvements or additions to the documentation label May 3, 2022
@danilo-leal danilo-leal requested a review from a team May 3, 2022 00:33
@mui-bot
Copy link

mui-bot commented May 3, 2022 •
edited

No bundle size changes

Generated by 🚫 dangerJS against 7794d6b

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 3, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 3, 2022
@siriwatknp
Copy link
Member

siriwatknp commented May 4, 2022 •
edited

At https://deploy-preview-32383--material-ui.netlify.app/joy-ui/getting-started/quick-start/

Screen Shot 2565-05-04 at 12 44 01

I think it is better to rewrite the heading to:

The [react](https://www.npmjs.com/package/react) >= 17.0.0 and [react-dom](https://www.npmjs.com/package/react-dom) >= 17.0.0 are peer dependencies.

## Emotion

with **npm**
// code block

with **yarn**
// code block

## Styled-components

with **npm**
// code block

with **yarn**
// code block

But this can be done in a separate PR. (Same as system installation page)

@siriwatknp

This comment was marked as resolved.

Sign in to view
siriwatknp
siriwatknp approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments, the rest looks good.

docs/data/base/getting-started/installation/installation.md Outdated Show resolved Hide resolved
@danilo-leal danilo-leal merged commit 752bb1a into mui:master May 5, 2022
@danilo-leal danilo-leal deleted the split-commands branch May 5, 2022 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

@michaldudak michaldudak Awaiting requested review from michaldudak

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danilo-leal @mui-bot @siriwatknp @michaldudak