Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix broken redirection #32581

Merged
merged 2 commits into from
May 3, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented May 3, 2022

I give up on this redirection pattern:

/:lang/YY/ /:lang/base/YY/ 301

It creates a mess when the page you try to reach is a 404. For instance, it makes so that https://mui.com/api/backdrop-unstyled/ is not a clear 404 but it should be.

I also fix this redirection https://mui.com/api/backdrop-unstyled/ now goes to https://mui.com/base/react-modal/ as we killed the component, at some point (it was private).

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label May 3, 2022
@oliviertassinari oliviertassinari changed the title [docs] [docs] Fix broken redirection May 3, 2022
@mui-bot
Copy link

mui-bot commented May 3, 2022

No bundle size changes

Generated by 🚫 dangerJS against c12ec80

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch with the Backdrop 👍

@oliviertassinari oliviertassinari merged commit f481834 into mui:master May 3, 2022
@oliviertassinari oliviertassinari deleted the docs-fix-redirections branch May 3, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants