-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Remove copy button on marketing pages #32649
Conversation
Slightly off topic to the purpose of PR, but since it's the first time seeing this feature, something doesn't look right in the browser you're using. Here's how it looks in Chrome: I also wonder if "or Cmd + C" should be in parentheses? "(Or Cmd + C)" And does this mean that we can remove the other button? |
Originally, the copy button is to to be used for markdown code block but I also added to the demo to make it consistent from the user perspective. The reason I kept the copy source button is because I don't want to interrupt the existing experience. My assumption is that users will incrementally discovered and started to use the new copy button and we can remove the old copy button later (the GA event had been setup to track this). The only downside of removing the old copy button is you can't copy the source without expanding the demo (but I guess this is not common because usually you have to see the code before you copy it). |
Thoughts on my other comments? |
without "+" sounds good to me. will update soon. For parentheses, I don't think there is no different than not having. cc @danilo-leal |
I'm good with adding the parenthesis, no strong preference. Sounds like a good strategy to monitor the "Copy the source" button versus this new one to know when it's a safe moment to remove the former 👍 |
Currently, the code block on marketing pages displays the copy button. We don't need the copy button on these pages. This PR specifies the
copyButtonHidden
prop to allHighlightedCode
in marketing pages.