Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Remove copy button on marketing pages #32649

Merged
merged 1 commit into from
May 6, 2022

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented May 6, 2022

Currently, the code block on marketing pages displays the copy button. We don't need the copy button on these pages. This PR specifies the copyButtonHidden prop to all HighlightedCode in marketing pages.

Screen Shot 2565-05-06 at 12 08 43

@siriwatknp siriwatknp added the docs Improvements or additions to the documentation label May 6, 2022
@mui-bot
Copy link

mui-bot commented May 6, 2022

No bundle size changes

Generated by 🚫 dangerJS against 5bef083

@danilo-leal danilo-leal added website Pages that are not documentation-related, marketing-focused. and removed docs Improvements or additions to the documentation labels May 6, 2022
@siriwatknp siriwatknp changed the title [docs] Remove copy button on marketing pages [website] Remove copy button on marketing pages May 6, 2022
@siriwatknp siriwatknp merged commit 9159325 into mui:master May 6, 2022
@mbrookes
Copy link
Member

mbrookes commented May 7, 2022

Slightly off topic to the purpose of PR, but since it's the first time seeing this feature, something doesn't look right in the browser you're using. Here's how it looks in Chrome:

image

I also wonder if "or Cmd + C" should be in parentheses? "(Or Cmd + C)"

And does this mean that we can remove the other button?

image

@mbrookes
Copy link
Member

mbrookes commented May 7, 2022

Also, MacOS doesn't use a "+":

image

@siriwatknp
Copy link
Member Author

And does this mean that we can remove the other button?

Originally, the copy button is to to be used for markdown code block but I also added to the demo to make it consistent from the user perspective. The reason I kept the copy source button is because I don't want to interrupt the existing experience. My assumption is that users will incrementally discovered and started to use the new copy button and we can remove the old copy button later (the GA event had been setup to track this).

The only downside of removing the old copy button is you can't copy the source without expanding the demo (but I guess this is not common because usually you have to see the code before you copy it).

@mbrookes
Copy link
Member

Thoughts on my other comments?

@siriwatknp
Copy link
Member Author

siriwatknp commented May 26, 2022

Thoughts on my other comments?

without "+" sounds good to me. will update soon.

For parentheses, I don't think there is no different than not having. cc @danilo-leal

@danilo-leal
Copy link
Contributor

I'm good with adding the parenthesis, no strong preference. Sounds like a good strategy to monitor the "Copy the source" button versus this new one to know when it's a safe moment to remove the former 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants