New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Joy] Add Slider
component and demos
#32694
Conversation
@mui/joy: parsed: +12.85% , gzip: +13.55% |
About the global variants, let's follow the For the component variables, here is what I think (quite similar to Switch): --Slider-track-height
--Slider-track-radius
--Slider-rail-height
--Slider-thumb-size
--Slider-thumb-shadow It's better to do the customization with different design eg. https://mui.com/material-ui/react-slider/#customization to see if the variables make sense, what are missing or too complicated. |
PropsvariantSorry about this Benny, I think let's remove the variant prop and go with one default design for the Slider. I feel that the slider is an exception for the global variants. Let's use this one as a default design: The color prop still exists. You can use this token for the default design: '--Slider-track-background': theme.vars.palette[color!]?.solidBg DemosCan you add the functionality demos similar to Material UI?
|
Slider
componentSlider
component and demos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I pushed some improvements about the variables to make it works with vertical slider and combine the colors & sizes into one demo
Done:
Docs: https://deploy-preview-32694--material-ui.netlify.app/joy-ui/react-slider/