Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript] Allow module augmentation for Mixins #32798

Merged
merged 5 commits into from
May 20, 2022

Conversation

mnajdova
Copy link
Member

I noticed while providing a solution to #32721 that we do not export the Mixins type from @mui/material/styles, leading to developers needing to declare module for it from a private path: @mui/material/styles/createMixins.

The goal is to allow the following:

-declare module "@mui/material/styles/createMixins" {
+declare module "@mui/material/styles" {
   interface Mixins {
     myCustomGuttersMixin: CSSProperties;
   }
 }

@mnajdova mnajdova changed the title [material] Export Mixins from index [typescript] Allow module augmentation for Mixins May 17, 2022
@mui-bot
Copy link

mui-bot commented May 17, 2022

No bundle size changes

Generated by 🚫 dangerJS against 113092d

@mnajdova mnajdova marked this pull request as ready for review May 18, 2022 11:00
@mnajdova mnajdova requested a review from siriwatknp May 19, 2022 07:28
@mnajdova mnajdova merged commit f859ef9 into mui:master May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants