Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slider] Slider having marks should be customizable in theme #32816

Merged
merged 2 commits into from
May 18, 2022

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented May 18, 2022

Fixes #32789

Slider's ownerState does not have marksProp property which is used to calculate marked but anyway marked is already calculated in the useSlider hook which is then later added in the ownerState.

Before: https://codesandbox.io/s/small-platform-us0i9x?file=/src/Demo.tsx
Now: https://codesandbox.io/s/winter-surf-gxrp6z?file=/src/Demo.tsx

@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module! labels May 18, 2022
@mui-bot
Copy link

mui-bot commented May 18, 2022

Details of bundle changes

Generated by 🚫 dangerJS against 0ecef76

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! One could argue that the change in SliderUnstyled is a breaking change as it is used in the Slider too, but I would say it is a fix indeed 👍

@mnajdova mnajdova merged commit c49fd6e into mui:master May 18, 2022
@ZeeshanTamboli ZeeshanTamboli deleted the issue/32789-slider-marked-prop branch May 18, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Slider] marked class in theme styleOverrides is not working
3 participants