Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lab] Update @mui/x-date-pickers to have the lab usable with React 18 #32828

Merged
merged 5 commits into from
May 19, 2022
Merged

[lab] Update @mui/x-date-pickers to have the lab usable with React 18 #32828

merged 5 commits into from
May 19, 2022

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented May 19, 2022 •
edited by oliviertassinari

Fixes mui/mui-x#4932
Fix #32319
Fix #32654

@flaviendelangle flaviendelangle added the component: pickers This is the name of the generic UI component, not the React module! label May 19, 2022
@flaviendelangle flaviendelangle self-assigned this May 19, 2022
@mui-bot
Copy link

mui-bot commented May 19, 2022 •
edited

Details of bundle changes

@material-ui/core: parsed: +Infinity% , gzip: +Infinity%
@material-ui/lab: parsed: +Infinity% , gzip: +Infinity%
@material-ui/styles: parsed: +Infinity% , gzip: +Infinity%
@material-ui/private-theming: parsed: +Infinity% , gzip: +Infinity%
@material-ui/system: parsed: +Infinity% , gzip: +Infinity%
@material-ui/unstyled: parsed: +Infinity% , gzip: +Infinity%
@material-ui/utils: parsed: +Infinity% , gzip: +Infinity%
@mui/material-next: parsed: +Infinity% , gzip: +Infinity%
@mui/joy: parsed: +Infinity% , gzip: +Infinity%

Generated by 🚫 dangerJS against 2997217

flaviendelangle
flaviendelangle commented May 19, 2022
View reviewed changes
docs/package.json
@@ -46,8 +46,8 @@
"@mui/x-data-grid": "^5.8.0",
"@mui/x-data-grid-generator": "^5.8.0",
"@mui/x-data-grid-pro": "^5.8.0",
"@mui/x-date-pickers": "^5.0.0-alpha.0",
"@mui/x-date-pickers-pro": "^5.0.0-alpha.0",
"@mui/x-date-pickers": "^5.0.0-alpha.3",
Copy link
Member Author

@flaviendelangle flaviendelangle May 19, 2022 •
edited by oliviertassinari

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the version on the doc to have less bugs on the examples (https://mui.com/x/)

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 19, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 19, 2022
@oliviertassinari
Copy link
Member

I have updated the issue description to mention two other issues I think this PR fixes.

@flaviendelangle flaviendelangle merged commit d3b0096 into mui:master May 19, 2022
@flaviendelangle flaviendelangle deleted the pickers-react-18 branch May 19, 2022 12:28
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label May 19, 2022
@oliviertassinari oliviertassinari changed the title [pickers] Update @mui/x-date-pickers to be usable with React 18 [lab] Update @mui/x-date-pickers to have the lab usable with React 18 May 19, 2022
@oliviertassinari oliviertassinari added package: lab Specific to @mui/lab and removed component: pickers This is the name of the generic UI component, not the React module! labels May 19, 2022
@oliviertassinari
Copy link
Member

oliviertassinari commented May 19, 2022 •
edited

I have renamed this PR title. I think that we solve a problem for developers who want to use components in the @mui/lab. For the pickers, developers would likely want to import the pickers npm package directly?

@flaviendelangle flaviendelangle changed the title [lab] Update @mui/x-date-pickers to have the lab usable with React 18 [lab] Update @mui/x-date-pickers to have the lab usable with React 18 May 19, 2022
alippai
alippai reviewed May 23, 2022
View reviewed changes
yarn.lock
version "5.0.0-alpha.0"
resolved "https://registry.yarnpkg.com/@mui/x-date-pickers/-/x-date-pickers-5.0.0-alpha.0.tgz#a62ffbab453d3c2dcd4ec20bd4f3f6338ad2ed3f"
integrity sha512-JTzTaNSWbxNi8KDUJjHCH6im0YlIEv88gPoKhGm7s6xCGT1q6FtMp/oQ40nhfwrJ73nkM5G1JXRIzI/yfsHXQQ==
"@mui/x-date-pickers@5.0.0-alpha.1":
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentional instead of alpha.3?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes
The goal here is just to avoid blocking users that uses the lab for others components than the pickers and who want React 18
But for the pickers, you should migrate to the new packages. Those components will soon leave the lab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alippai alippai alippai left review comments

@mnajdova mnajdova mnajdova approved these changes

@alexfauquette alexfauquette alexfauquette approved these changes

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

Assignees

@flaviendelangle flaviendelangle

Labels
bug 🐛 Something doesn't work package: lab Specific to @mui/lab
Projects
None yet
Milestone
No milestone
6 participants
@flaviendelangle @mui-bot @oliviertassinari @alippai @mnajdova @alexfauquette