[Joy] Batch a couple of documentation refinements #33158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-leal
added
docs
|
@mui/joy: parsed: -0.25% 😍, gzip: -0.01% 😍 |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
added
PR: out-of-date
…h-joy-refinements
github-actions
bot
removed
the
PR: out-of-date
Merged
|
I'll merge this one for this week's release given the documentation organization and color palette updates! There are for sure many opportunities for improvement here so let's revise it further down the road. Didn't want to let it go past 20 days also 😅 |
1 task
There was a problem hiding this comment.
https://www.notion.so/mui-org/Engineering-philosophy-ec1615511f594782a8a2adeec3e25143#8d36ec1163de460fbc7059747855e8e3. I get that we can skip the reviews for small PRs, but here, there are over 1,000 LOCs changed. I think that one approved review would have been great.
A couple of regressions:
- https://deploy-preview-33158--material-ui.netlify.app/joy-ui/main-features/global-variants/ doesn't open on the side nav
- https://deploy-preview-33158--material-ui.netlify.app/blog/first-look-at-joy/#global-variants the link "Global variants" is a 404.
Merged
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this one to do some overall cleanup of the docs we currently already have + demos design + some design iteration as well. Deploy preview: https://deploy-preview-33158--material-ui.netlify.app/joy-ui/getting-started/overview/