-
-
Notifications
You must be signed in to change notification settings - Fork 32k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Improve the Base Usage page #33272
Conversation
Co-authored-by: Siriwat K <siriwatkunaporn@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one detail, not sure if it is important to be emphasized :)
https://deploy-preview-33272--material-ui.netlify.app/base/getting-started/usage/
I've gotten a better understanding of the component slots and the props that control them as I've been documenting them in #33156, so this PR adds some clarification to the Base Usage page where they're explained in detail.
Changes include:
components
andcomponentsProps
componentsProps
andcomponents
may be redundant for components that only have a root slot