Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add Grid version 2 docs #33554

Merged
merged 17 commits into from
Aug 2, 2022
Merged

Conversation

@siriwatknp siriwatknp added docs Improvements or additions to the documentation component: Grid The React component. labels Jul 18, 2022
@mui-bot
Copy link

mui-bot commented Jul 18, 2022

No bundle size changes

Generated by 🚫 dangerJS against 4374b16


## What's changed

We build Grid v2 from scratch in order to:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add note at the top of the page about why this components exists and is named Grid v2 :)

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, have left one comment. Will leave the copywriting review for @samuelsycamore

Copy link
Member

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed grid2.md up to line 57. Will return to finish reviewing ASAP!

docs/data/material/components/grid2/grid2.md Outdated Show resolved Hide resolved
docs/data/material/components/grid2/grid2.md Outdated Show resolved Hide resolved
docs/data/material/components/grid2/grid2.md Outdated Show resolved Hide resolved
docs/data/material/components/grid2/grid2.md Outdated Show resolved Hide resolved
docs/data/material/components/grid2/grid2.md Outdated Show resolved Hide resolved
docs/data/material/components/grid2/grid2.md Outdated Show resolved Hide resolved
docs/data/material/components/grid2/grid2.md Outdated Show resolved Hide resolved
docs/data/material/components/grid2/grid2.md Outdated Show resolved Hide resolved
docs/data/material/components/grid2/grid2.md Outdated Show resolved Hide resolved
docs/data/material/components/grid2/grid2.md Outdated Show resolved Hide resolved
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
docs/data/material/components/grid2/grid2.md Outdated Show resolved Hide resolved
docs/data/material/components/grid2/grid2.md Outdated Show resolved Hide resolved
docs/data/material/components/grid2/grid2.md Outdated Show resolved Hide resolved
docs/data/material/components/grid2/grid2.md Outdated Show resolved Hide resolved
docs/data/material/components/grid2/grid2.md Show resolved Hide resolved
siriwatknp and others added 6 commits July 29, 2022 09:43
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Copy link
Member

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it! 🚀

@siriwatknp siriwatknp merged commit 5009907 into mui:master Aug 2, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Grid The React component. docs Improvements or additions to the documentation
Projects
None yet
4 participants