-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Textarea][Joy] Add Textarea
component
#33975
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…textarea-component
siriwatknp
added
component: TextareaAutosize
The React component.
package: joy-ui
Specific to @mui/joy
labels
Aug 18, 2022
@mui/joy: parsed: +3.62% , gzip: +3.04% |
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Aug 22, 2022
2 tasks
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Aug 23, 2022
siriwatknp
commented
Aug 24, 2022
siriwatknp
commented
Aug 24, 2022
danilo-leal
approved these changes
Aug 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! Just pushed very minor tweaks but other than that, it's great!
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-33975--material-ui.netlify.app/joy-ui/react-textarea/
Motivation
Even though
input
andtextarea
are quite similar but their props and default styles are different.I don't think combining them like this is a good thing:
This PR split the Textarea into its own component which removes the typescript headache and makes the component easier to reason about (closer to the native html).
In the next PR, it will be
TextareaField
which combinesTextarea
,FormLabel
andFormHelperText
.The supported props and structure are consistent with the
Input
.