-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Improve feedback precision #34641
Merged
Merged
Changes from 1 commit
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
63319ac
first try
alexfauquette acd727e
customize a bit
alexfauquette f000559
remove context, only rely on event dispatch
alexfauquette 8bd78cd
Only display buttons when feedback footer is available
alexfauquette 3141e6d
add the hash to the slack message
alexfauquette 56dfe02
manage undefined up/down vote
alexfauquette d787afc
Merge remote-tracking branch 'upstream/master' into improve-feedbacks
alexfauquette 317907d
remove early thanks
alexfauquette 3fff812
remove section selector
alexfauquette 9915504
make the submit more visible
alexfauquette 27fc469
fix accessibility
alexfauquette ef60d25
inline CSS
alexfauquette fa2da76
prettier
alexfauquette 2534cda
Merge remote-tracking branch 'upstream/master' into improve-feedbacks
alexfauquette 6940285
add a link to github issue
alexfauquette 929eb2c
Apply suggestions from code review
alexfauquette 11f33ad
wordings
alexfauquette 36fd434
button alignments
alexfauquette f79b446
Merge remote-tracking branch 'upstream/master' into improve-feedbacks
alexfauquette 0ea5e20
vertically align
alexfauquette bf5c0c1
feedbacks
alexfauquette 40beb69
inver call to action and form actions
alexfauquette 26de531
tweak layout
oliviertassinari a0bc9be
GitHub
oliviertassinari 308595e
avoid style duplication and fix dark mode
oliviertassinari ec013b4
allow to reset to the whole page
oliviertassinari 8e6a1d7
Merge branch 'master' into improve-feedbacks
oliviertassinari 573facf
Alex's feedback, revert change
oliviertassinari 02c4d0c
[website] Exclude experiment pages in production (#35180)
siriwatknp 3f2e780
[website] Fix theme mode toggle state (#35216)
siriwatknp edfad73
Bump Font awesome SVG icons to ^6.2.1 (#35207)
renovate[bot] b9e220f
Bump @types/react-dom to ^18.0.9 (#35206)
renovate[bot] 0d9dc7a
Bump @types/lodash to ^4.14.189 (#35205)
renovate[bot] 1d0c387
Bump @chakra-ui/system to ^2.3.3 (#35204)
renovate[bot] 4f373b9
Bump webpack to ^5.75.0 (#35128)
renovate[bot] 5ff07ba
Bump typescript-eslint to ^5.43.0 (#35127)
renovate[bot] 91a5f74
Bump marked to ^4.2.3 (#35126)
renovate[bot] 85a40ba
Bump danger to ^11.2.0 (#35124)
renovate[bot] 1a4156a
Bump cimg/node Docker tag to v14.21 (#35123)
renovate[bot] c7f70a8
Bump aws-sdk to ^2.1258.0 (#35121)
renovate[bot] d921f78
Bump postcss to ^8.4.19 (#35119)
renovate[bot] b3067cf
Bump loader-utils from 2.0.3 to 2.0.4 (#35186)
dependabot[bot] 4767ba7
[website] Add Security questionnaire in pricing (#35172)
oliviertassinari 5d79e10
Bump babel-loader to ^8.3.0 (#35122)
renovate[bot] a1e5c37
Bump theme-ui to ^0.15.4 (#35120)
renovate[bot] cca882e
[docs] Fix confusion in TOCs when reaching scroll bottom (#35214)
oliviertassinari f9a8b86
[Joy] Uplift introduction demos & make consistent with Base (#34316)
danilo-leal 9a2d5d4
[icons] Update the Material Design icons (#35194)
michaldudak f409f94
[l10n] Add Urdu (ur-PK) locale (#35154)
MBilalShafi 12d631a
[Material You] Add theme structure & Button component (#34650)
mnajdova 447d0a9
[docs] Change MUI -> Material UI in icons-material's readme (#35220)
michaldudak 4a1af80
Convert icons scripts to ESM (#35101)
Janpot 52a26f2
[Autocomplete] Fix keyboard navigation when using custom popover (#35…
sai6855 14304e3
[docs] Fix a couple documentation errors (#35217)
danilo-leal ff98e23
5.10.15 (#35221)
siriwatknp 3e21bc0
typo fix
alexfauquette e8e009b
Olivier feedbacks
alexfauquette bd63ff8
Merge remote-tracking branch 'upstream/master' into improve-feedbacks
alexfauquette fe883b2
make template customizable
alexfauquette File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm adding this variable because github template will not necessarily have the same name on each repo. For example on X we already have a 4.xxxx.yml template