Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Fix subscribe input with Safari #34869

Merged
merged 1 commit into from Oct 26, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Oct 23, 2022

The issue can be seen at the bottom of any blog post, e.g. https://mui.com/blog/mui-x-v6-alpha-zero/

Screenshot 2022-10-23 at 18 32 45

I have used the opportunity to fix the autofill style on Chrome:

Screenshot 2022-10-23 at 18 55 04

@oliviertassinari oliviertassinari added design This is about UI or UX design, please involve a designer website Pages that are not documentation-related, marketing-focused. labels Oct 23, 2022
@oliviertassinari oliviertassinari requested review from DanailH and danilo-leal and removed request for DanailH October 23, 2022 16:55
@mui-bot
Copy link

mui-bot commented Oct 23, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-34869--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 7cb16b1

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks great! It's so annoying that outline doesn't properly work on Safari...

@oliviertassinari oliviertassinari changed the title [website] Fix Safari subscribe input [website] Fix subscribe input with Safari Oct 26, 2022
@oliviertassinari oliviertassinari merged commit 14fa2e5 into mui:master Oct 26, 2022
@oliviertassinari oliviertassinari deleted the safari-fix-outline branch October 26, 2022 13:54
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Oct 26, 2022

@danilo-leal Yeah, I think the learning for me is that the only valid use case is outline: 0 when there are better ways to handle the a11y focus ring.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Oct 26, 2022

We will need to fix https://mui.com/base/react-input/#introduction too, do you want to take care of it?

Screenshot 2022-10-26 at 16 00 03

Safari is 18.86% of the browser shares.

@danilo-leal
Copy link
Contributor

Sure, I'll do it in one of my PRs. That's really a bummer... outline reads so much better than box-shadow for this, which never ceases to feel hacky 😅

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Nov 2, 2022

Sure, I'll do it in one of my PRs.

@danilo-leal Thanks. Only please don't bundle it with unrelated changes, in case this is what you meant 😁. For example, a 10 LOCs PR is great to be able git blame and understand the history.

daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
@michaldudak
Copy link
Member

FYI, this bug apparently has been fixed in Safari Technology Preview Release 157 (https://developer.apple.com/safari/technology-preview/release-notes/#r157), released on Nov 7. So chances are the next stable update will include the fix.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Dec 7, 2022

@michaldudak So we might need this for another 12-24 months? How long will it take for, say 80% of the iOS/macOS users to get the fix? https://caniuse.com/mdn-css_properties_outline

Screenshot 2023-02-14 at 01 56 07

@michaldudak
Copy link
Member

Perhaps a bit less. I'm looking at focus:visible support, which was introduced in Safari 15.4 on March 14, 2022. It seems that users of supported versions represent almost 15% of all, and older Safari users are 2.9% of all. So, after nine months, almost 84% of all Safari users have this feature working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work design This is about UI or UX design, please involve a designer website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants