New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Fix subscribe input with Safari #34869
[website] Fix subscribe input with Safari #34869
Conversation
|
f45a908
to
7cb16b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, looks great! It's so annoying that outline
doesn't properly work on Safari...
@danilo-leal Yeah, I think the learning for me is that the only valid use case is |
We will need to fix https://mui.com/base/react-input/#introduction too, do you want to take care of it? Safari is 18.86% of the browser shares. |
Sure, I'll do it in one of my PRs. That's really a bummer... |
@danilo-leal Thanks. Only please don't bundle it with unrelated changes, in case this is what you meant 😁. For example, a 10 LOCs PR is great to be able git blame and understand the history. |
FYI, this bug apparently has been fixed in Safari Technology Preview Release 157 (https://developer.apple.com/safari/technology-preview/release-notes/#r157), released on Nov 7. So chances are the next stable update will include the fix. |
@michaldudak So we might need this for another 12-24 months? How long will it take for, say 80% of the iOS/macOS users to get the fix? https://caniuse.com/mdn-css_properties_outline |
Perhaps a bit less. I'm looking at |
The issue can be seen at the bottom of any blog post, e.g. https://mui.com/blog/mui-x-v6-alpha-zero/
I have used the opportunity to fix the autofill style on Chrome: