Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Template] Add iOS theme to Joy UI #34994

Closed
wants to merge 24 commits into from

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Nov 3, 2022

@siriwatknp siriwatknp added docs Improvements or additions to the documentation design: joy This is about Joy Design, please involve a visual or UX designer in the process labels Nov 3, 2022
@mui-bot
Copy link

mui-bot commented Nov 3, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-34994--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 99c5884

@vitalijalbu
Copy link

vitalijalbu commented Nov 3, 2022

For ios theme guys you can take inspiration from framework7, it’s really nice open source ui design library.

@siriwatknp
Copy link
Member Author

For ios theme guys you can take inspiration from framework7, it’s really nice open source ui design library.

🤩 Thanks! will definitely check it out. Currently, I follow the official design resources from Apple website.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 8, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 15, 2022
Comment on lines +359 to +363
unstable_sxConfig: {
material: {
style: (props) => props.theme.materials?.[props.material],
},
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mnajdova Got a nice use case for this!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, would be great if you can share more feedback (related to things that can be improved) :)

@siriwatknp siriwatknp self-assigned this Jan 3, 2023
@oliviertassinari
Copy link
Member

I have linked #21911 in the PR description.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 3, 2023
@siriwatknp siriwatknp closed this Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design: joy This is about Joy Design, please involve a visual or UX designer in the process docs Improvements or additions to the documentation PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants