-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][joy] Improved readability on theme tokens page #35639
Conversation
Signed-off-by: badal <14058003+badalsaibo@users.noreply.github.com>
|
1. [Low-level tokens](#low-level-tokens) | ||
2. [Global variant tokens](#global-variant-tokens) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, unordered list is better for this:
1. [Low-level tokens](#low-level-tokens) | |
2. [Global variant tokens](#global-variant-tokens) | |
- [Low-level tokens](#low-level-tokens) | |
- [Global variant tokens](#global-variant-tokens) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. I gave it a numbered list because of the description clearly mentioning two categories.
to develop its theme, consisting of two categories
An unordered list is also valid if future iterations would make require more than two categories.
Let me know what should I do. 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An ordered list should be no problem in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Left one suggestion. Can you also run yarn prettier
and push the formatting changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks for your contribution!
While reading, wanted to navigate quickly b/w these two sections and couldn't do that.
So added that with this PR.