Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Portal][base] Convert code to TypeScript #35657

Merged
merged 4 commits into from
Jan 5, 2023
Merged

[Portal][base] Convert code to TypeScript #35657

merged 4 commits into from
Jan 5, 2023

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Dec 28, 2022 •
edited
Loading

closes: #34719

@mui-bot
Copy link

mui-bot commented Dec 28, 2022 •
edited
Loading

Messages
📖 Netlify deploy preview: https://deploy-preview-35657--material-ui.netlify.app/

Details of bundle changes

Generated by 🚫 dangerJS against bcbdc62

@sai6855 sai6855 marked this pull request as draft December 28, 2022 18:02
@sai6855 sai6855 marked this pull request as ready for review December 28, 2022 18:25
@sai6855 sai6855 mentioned this pull request Dec 28, 2022
Closed
@ZeeshanTamboli ZeeshanTamboli changed the title [Portal] Convert Portal to typescript [Portal][base] Convert code to TypeScript Dec 29, 2022
@ZeeshanTamboli ZeeshanTamboli added typescript component: Portal The React component. package: base-ui Specific to @mui/base labels Dec 29, 2022
michaldudak
michaldudak approved these changes Dec 29, 2022
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for such a quick PR!

@michaldudak michaldudak mentioned this pull request Dec 29, 2022
Closed
1 task
@ankushrana830

This comment was marked as spam.

Sign in to view
@hbjORbj hbjORbj merged commit 415aa41 into mui:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

Assignees
No one assigned
Labels
component: Portal The React component. package: base-ui Specific to @mui/base typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Portal][base] Convert code to TypeScript
6 participants
@sai6855 @mui-bot @ankushrana830 @michaldudak @ZeeshanTamboli @hbjORbj