Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SelectField] Keyboard navigation support #3583

Closed
wants to merge 1 commit into from
Closed

[SelectField] Keyboard navigation support #3583

wants to merge 1 commit into from

Conversation

chrismcv
Copy link
Contributor

@chrismcv chrismcv commented Mar 3, 2016

Closes #2947

  • PR has docs, demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@chrismcv
Copy link
Contributor Author

chrismcv commented Mar 3, 2016

FYI @mbrookes @oliviertassinari @bgribben

@chrismcv chrismcv changed the title Select Field Keyboard support [SelectField] Keyboard navigation support Mar 3, 2016
@chrismcv chrismcv mentioned this pull request Mar 3, 2016
Closed
@mbrookes mbrookes mentioned this pull request Mar 4, 2016
Closed
@mbrookes mbrookes added the accessibility a11y label Mar 5, 2016
mbrookes
mbrookes reviewed Mar 6, 2016
View reviewed changes
src/DropDownMenu/DropDownMenu.jsx
case 13:
case 32:
case 40:
event.preventDefault();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use keycode here? (https://github.com/timoxley/keycode)

It was added to other components recently.

@mbrookes mbrookes self-assigned this Mar 7, 2016
@chrismcv chrismcv mentioned this pull request Mar 7, 2016
Closed
3 tasks
@chrismcv chrismcv closed this Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrookes mbrookes

Labels
accessibility a11y
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chrismcv @mbrookes