[docs] Revise Joy UI "Circular Progress" page #36126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zannager
added
docs
There was a problem hiding this comment.
Thanks @LadyBluenotes ! This is looking great. One thing the page could still use is an explanation of the value prop. Maybe this would make sense to cover in the Basics section?
As for details on accessibility, I'd say the more the merrier! You could definitely talk about the aria labels.
docs/data/joy/components/circular-progress/circular-progress.md
Outdated
Show resolved
Hide resolved
docs/data/joy/components/circular-progress/circular-progress.md
Outdated
Show resolved
Hide resolved
docs/data/joy/components/circular-progress/circular-progress.md
Outdated
Show resolved
Hide resolved
docs/data/joy/components/circular-progress/circular-progress.md
Outdated
Show resolved
Hide resolved
docs/data/joy/components/circular-progress/circular-progress.md
Outdated
Show resolved
Hide resolved
docs/data/joy/components/circular-progress/circular-progress.md
Outdated
Show resolved
Hide resolved
docs/data/joy/components/circular-progress/circular-progress.md
Outdated
Show resolved
Hide resolved
docs/data/joy/components/circular-progress/circular-progress.md
Outdated
Show resolved
Hide resolved
docs/data/joy/components/circular-progress/circular-progress.md
Outdated
Show resolved
Hide resolved
LadyBluenotes
requested review from
samuelsycamore
and removed request for
siriwatknp
|
Was reaching out to see if there was anything else I needed to update for this! |
siriwatknp
approved these changes
Mar 27, 2023
samuelsycamore
approved these changes
Mar 27, 2023
61 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #33998
Hey @samuelsycamore!
Thought I'd try my hand at another.
When I was doing this one, it didn't have an accessibility component, so I added the color ratio part. I noticed built into the component, there's ARIA labels already. I was contemplating adding them to the accessibility part but I'm not sure whether you're adding how to make components accessible in this, or explaining some of the out-of-the-box things.
The anatomy section also threw me off a bit. I know that adding the classes is important but I wasn't able to find any examples that had something similar to this one, where SVG tags and a circle tag was involved (really didn't even know this was an HTML tag lol).
Let me know what you think and if there's anything else I need to revise!
Hope you're having a great day,