[docs] Add accordion coming soon page #36279
Conversation
siriwatknp
commented
Feb 21, 2023
•
siriwatknp
commented
- I have followed (at least) the PR section of the contributing guide.
siriwatknp
added
docs
Netlify deploy previewBundle size report |
|
@samuelsycamore what do you think about the structure of the page? https://deploy-preview-36279--material-ui.netlify.app/joy-ui/react-accordion/ |
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com> Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
…accordion-docs
|
@samuelsycamore could you do a final review? |
| This document shows how construct an accordion with existing Joy UI components combined with popular headless UI libraries. | ||
| ::: | ||
|
|
||
| If you're in need of a Joy UI Accordion, please upvote [this issue](https://github.com/mui/material-ui/issues/36281) to help us prioritize the next batch of new components. |
There was a problem hiding this comment.
What do you think about following the same frame as https://mui.com/x/react-data-grid/pivoting/ only so that developer can recognize the pattern? Humm, not sure.
Actually, much better: we could connect this with https://github.com/mui/material-ui/pull/36279/files#r1143883693, it could be one warning callout with 3 small paragraphs:
- Not ready
- Upvote to make it move faster
- Can't wait? recreate it with other headless libraries
👌
|
|
||
| <p class="description">Accordions let users show and hide sections of related content on a page.</p> | ||
|
|
||
| :::success |
There was a problem hiding this comment.
I'm a bit confused by the callout type. https://www.notion.so/mui-org/Callouts-and-their-usage-in-the-docs-7e709a02c72142cd8b1a0829861435c5 I would expect success as all is great, but the fact that it's not built-in makes me weigh a bit more toward info or even better warning to match/hint to the color in the side nav:
| This document shows how construct an accordion with existing Joy UI components combined with popular headless UI libraries. | ||
| ::: | ||
|
|
||
| If you're in need of a Joy UI Accordion, please upvote [this issue](https://github.com/mui/material-ui/issues/36281) to help us prioritize the next batch of new components. |
There was a problem hiding this comment.
To be more specific?
| If you're in need of a Joy UI Accordion, please upvote [this issue](https://github.com/mui/material-ui/issues/36281) to help us prioritize the next batch of new components. | |
| If you're in need of a Joy UI Accordion, please upvote [issue #36281](https://github.com/mui/material-ui/issues/36281) to help us prioritize the next batch of new components. |
|
@siriwatknp & @samuelsycamore I've pushed some changes in the direction that Olivier steered this PR in (which I think it's great!). Let me know what y'all think ⎯ in the meantime, I'll create a similar PR to this one for the Snackbar component. |
|
Fair enough, I guess the yellow/orange makes more sense for deprecated APIs like in https://mui.com/system/styles/basics/.
|
| 💡 The Joy UI Accordion component is still in development. | ||
| If you're in need of it, please upvote [**this issue**](https://github.com/mui/material-ui/issues/36281) to help us prioritize the next batch of new components. |
There was a problem hiding this comment.
| 💡 The Joy UI Accordion component is still in development. | |
| If you're in need of it, please upvote [**this issue**](https://github.com/mui/material-ui/issues/36281) to help us prioritize the next batch of new components. | |
| 💡 The Joy UI Accordion component is still in development. | |
| If you're in need of it, please upvote [**this issue**](https://github.com/mui/material-ui/issues/36281) to help us prioritize the next batch of new components. | |
| Or you can use the Accordion component from headless libraries and leverage the Joy UI theme. See [examples](integration-with-headless-ui-libraries) below. |
How about this? @danilo-leal @oliviertassinari @samuelsycamore
There was a problem hiding this comment.
I've done some tweaking exactly on this part! I think it works having the first two sentences in an info callout. Let me know what you think! 👉 https://deploy-preview-36279--material-ui.netlify.app/joy-ui/react-accordion/
github-actions
bot
added
the
PR: out-of-date
Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
github-actions
bot
removed
the
PR: out-of-date
|
When I land on the page, the current style makes me want to click on the page that aren't built yet, would a grey color make more sense (for the list item too)? Radix UI 
Material UI
It might also be better with a shorter text:
MUI X:
|
|
@oliviertassinari yeah ⎯ good call about the color! In hindsight, it's definitely grabbing too much attention for something that, indeed, isn't available yet. Let me tackle that! Wouldn't change the copy, though. Those components are not really a "work in progress" yet ⎯ they could be, but not necessarily. |
