[core] Use glob to find the test files in parseTest #36305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-36305--material-ui.netlify.app/ Bundle size report |
|
Is using |
github-actions
bot
added
the
PR: out-of-date
flaviendelangle
force-pushed
the
test-files-parsing
branch
from
93f0ff2
to
08c51e8
Compare
github-actions
bot
removed
the
PR: out-of-date
|
@michaldudak seems to work fine indeed, thanks ! |
flaviendelangle
force-pushed
the
test-files-parsing
branch
from
08c51e8
to
8032dec
Compare
|
@michaldudak if you can please have a look at the PR 👼 |
michaldudak
reviewed
Apr 14, 2023
Co-authored-by: Michał Dudak <michal.dudak@gmail.com> Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
oliviertassinari
added
scope: code-infra
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effect on mui-x: mui/mui-x#8483
Revert #34789 (see sindresorhus/globby#193)
On X, most of our tests are in files named
{component}/tests/{feature}.{component}.test.tsxFor example
src/TimeField/tests/editing.TimeField.test.tsx.This allow us to have several test files per component, especially for big ones with often several thousands of lines of test.
In it's current form,
parseTestdoes not support those test files, so our doc does not have the correctforwardsRefTo,inheritComponentandspreadproperties.To fix that, I introduced a glob matching in
parseTest.But
globbyis pure ESM and our api builder process is not.So I downgraded
globbyto the last version working correctly with our current infra.If you have another solution, I'm interested because I am fully aware that downgrading a library like that is not great.
But on the other hand, migrating a thousand long set of scripts across 2 repo just for this use case will take a lot of time :/