[useMenuItem] Add explicit return type #36359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-36359--material-ui.netlify.app/ Bundle size report |
zannager
added
the
component: menu
hbjORbj
previously requested changes
Mar 2, 2023
|
@hbjORbj Thanks for the reviews! |
rayrw
force-pushed
the
use-menu-item-return-value
branch
from
bf3de6c
to
737ed6e
Compare
15 tasks
ZeeshanTamboli
approved these changes
Mar 7, 2023
There was a problem hiding this comment.
@rayrw It's a great first pull request on MUI 👌 Thank you for working on it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the
useMenuItempart of this issue #35933