[Grid2] Support dynamic nested columns #36401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
bug 🐛
siriwatknp
changed the title
Netlify deploy previewBundle size report |
mnajdova
approved these changes
Mar 20, 2023
|
@siriwatknp should we merge this one? |
|
would be possible to check if this issue: is cause by this pr? I think this doesn't work if the parent is not a grid, I Was able to fix the issue above adding the columns prop, not sure if we should default the column prop to the theme column number |
|
@francescovenica most likely. I just noticed the same issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #36335
Before:
The nested grid container does not get the
--Grid-columnsvalue from its parent because it is overridden by its own variable. The fix is similar to how nested spacing works.https://stackblitz.com/edit/react-6xxqec?file=demo.tsx
After
https://codesandbox.io/s/material-cra-ts-forked-55ep57?file=/src/App.tsx