Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blog] Improvements on v6 announcement blog #36505

Merged

Conversation

joserodolfofreitas
Copy link
Member

@joserodolfofreitas joserodolfofreitas commented Mar 13, 2023

Summary

General Improvements that weren't blocking the blog post's release.

  • Add Table of Contents
  • Add web worker as a feature highlight for Data Grid.
  • Highlight the Fields first on Date Pickers sub-section.

Preview

https://deploy-preview-36505--material-ui.netlify.app/blog/mui-x-v6/

@joserodolfofreitas joserodolfofreitas changed the title [blog] 2nd iteration on v6 announcement blog [blog] Improvements on v6 announcement blog Mar 13, 2023
@mui-bot
Copy link

mui-bot commented Mar 13, 2023

Netlify deploy preview

https://deploy-preview-36505--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 1c56324

@joserodolfofreitas joserodolfofreitas marked this pull request as ready for review March 15, 2023 19:29
@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 21, 2023

Alright, I went above and beyond on this review 😁:

  • I have updated the https://www.notion.so/mui-org/Blog-247ec2bff5fa46e799ef06a693c94917#9c47cb10d26e4a95be23b01fdb96f431 to cover the need to add the intrinsic dimensions of the videos and added them to avoid layout shifts
  • I have sorted the headers to always be 1. community 2. pro 3. premium
  • I have fixed a few typos
  • I have added more visuals
  • I have flattened the heading structure to be easier to navigate
  • I have removed all the links in the headers as I feel that it makes it harder to browse the content, and also, doesn't always clearly label what the link is about
  • I have compressed images
  • I have explained why we moved a feature from the Pro to the MIT plan.

@oliviertassinari oliviertassinari force-pushed the 2nd-iteration-v6-blog branch 2 times, most recently from a854141 to 8e0652e Compare March 21, 2023 18:32
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think of anything else that could be improved, I went after all the avenues I wasn't blind on. I love it!

@oliviertassinari oliviertassinari added component: data grid This is the name of the generic UI component, not the React module! component: pickers This is the name of the generic UI component, not the React module! labels Mar 21, 2023
docs/pages/blog/mui-x-v6.md Outdated Show resolved Hide resolved
docs/pages/blog/mui-x-v6.md Outdated Show resolved Hide resolved
docs/pages/blog/mui-x-v6.md Outdated Show resolved Hide resolved
docs/pages/blog/mui-x-v6.md Outdated Show resolved Hide resolved
@joserodolfofreitas
Copy link
Member Author

joserodolfofreitas commented Mar 22, 2023

I can't think of anything else that could be improved, I went after all the avenues I wasn't blind on. I love it!

Thanks for the great improvements, @oliviertassinari. I love it too!
It will be the baseline for the next blog posts.

Copy link
Member

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like great improvements to an already very well done piece! 🙌 Love the table of contents. We might even want to consider autogenerating these on the blog in the same way we do in the docs.

@joserodolfofreitas joserodolfofreitas merged commit 72af077 into mui:master Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blog component: data grid This is the name of the generic UI component, not the React module! component: pickers This is the name of the generic UI component, not the React module! MUI X
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants