Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release] v5.11.13 #36507

Merged
merged 7 commits into from
Mar 14, 2023
Merged

[release] v5.11.13 #36507

merged 7 commits into from
Mar 14, 2023

Conversation

mnajdova
Copy link
Member

You can tell we were on a retreat :D

@mnajdova mnajdova added the release We are shipping :D label Mar 13, 2023
@mui-bot
Copy link

mui-bot commented Mar 13, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-36507--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against cc91336

michaldudak
michaldudak reviewed Mar 13, 2023
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The versions look good. Aside from that, just two minor remarks.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@mnajdova mnajdova marked this pull request as ready for review March 13, 2023 16:21
mnajdova and others added 2 commits March 13, 2023 17:22
@mnajdova @michaldudak
Apply suggestions from code review
75460b5 
Co-authored-by: Michał Dudak <michal.dudak@gmail.com>
Signed-off-by: Marija Najdova <mnajdova@gmail.com>
@mnajdova
Michal's review
6558149
@sai6855
Copy link
Contributor

sai6855 commented Mar 13, 2023

Can this PR included in this release?

@mnajdova
Copy link
Member Author

Can this #36458 included in this release?

I approved, but let's wait on Michal's final say before we merge it.

@ZeeshanTamboli
Copy link
Member

This PR can also be reveiwed and included.

@mnajdova
Copy link
Member Author

This #33621 can also be reveiwed and included.

I will check this tomorrow. Will do the release tomorrow too.

hbjORbj
hbjORbj approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@hbjORbj hbjORbj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! FYI, I merged 2 more PRs of mine.

hbjORbj
hbjORbj previously requested changes Mar 13, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@mnajdova @hbjORbj
Update CHANGELOG.md
1bbce25 
Co-authored-by: Benny Joo <sldisek783@gmail.com>
Signed-off-by: Marija Najdova <mnajdova@gmail.com>
@mnajdova
Copy link
Member Author

I am preparing the release. @sai6855 we can include the PR you mentioned in the next release.

@mnajdova mnajdova requested a review from hbjORbj March 14, 2023 09:08
@mnajdova mnajdova dismissed hbjORbj’s stale review March 14, 2023 09:44

Addressed comments

@mnajdova mnajdova merged commit 9f7a2bf into mui:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

@hbjORbj hbjORbj Awaiting requested review from hbjORbj

Assignees
No one assigned
Labels
release We are shipping :D
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mnajdova @mui-bot @sai6855 @ZeeshanTamboli @michaldudak @hbjORbj