Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stepper] Add aria-current to the active StepButton #36526

Merged
merged 2 commits into from
Mar 16, 2023
Merged

[Stepper] Add aria-current to the active StepButton #36526

merged 2 commits into from
Mar 16, 2023

Conversation

michalak111
Copy link
Contributor

@michalak111 michalak111 commented Mar 15, 2023 •
edited
Loading

closes #36475

@zannager zannager added the component: stepper This is the name of the generic UI component, not the React module! label Mar 16, 2023
@mui-bot
Copy link

mui-bot commented Mar 16, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-36526--material-ui.netlify.app/

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against 2773d6f

michaldudak
michaldudak approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good.
It's a great first PR in Material UI!

@michaldudak michaldudak changed the title [Stepper] add aria-current to active StepButton [Stepper] Add aria-current to the active StepButton Mar 16, 2023
@michaldudak michaldudak merged commit 0a630d8 into mui:master Mar 16, 2023
@michalak111 michalak111 deleted the fix-stepbutton-aria-current branch March 16, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

Assignees
No one assigned
Labels
component: stepper This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Stepper] Screen readers do not announce the active step
4 participants
@michalak111 @mui-bot @michaldudak @zannager