Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextField] Improve IntelliSense support for props #36737

Merged
merged 14 commits into from
May 2, 2023

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Apr 1, 2023

closes #36232
closes #36862

Both issues mentioned above are sort of linked to each other, i found #36862 while working in this PR. Initially i opened new PR which fixes #36862 but @ZeeshanTamboli suggested to combine fixes for both issues as they both are sort of related here

Description for #36232 :
From trial & error, i got to know Intellisense is not extracting description when type is union type and for conditional type intellisense is able to correctly extract info.

Since existing tests from this file has enough coverage, i haven't added any tests.

Before for #36232:
Screenshot 2023-04-01 at 9 06 43 AM

AFTER for #36232:
Screenshot 2023-04-01 at 9 06 12 AM

working code sandbox for #36232 : https://codesandbox.io/s/peaceful-rosalind-purnu8?file=/demo.tsx

before codesandbox for #36862 : https://codesandbox.io/s/infallible-haibt-ytenql?file=/styles.css:0-38
after codesandbox for #36862: https://codesandbox.io/s/goofy-leavitt-428poo?file=/demo.tsx

@sai6855 sai6855 added bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! typescript labels Apr 1, 2023
@mui-bot
Copy link

mui-bot commented Apr 1, 2023

Netlify deploy preview

https://deploy-preview-36737--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against e3491ab

@sai6855 sai6855 marked this pull request as draft April 1, 2023 03:47
@sai6855 sai6855 marked this pull request as ready for review April 1, 2023 04:05
@sai6855 sai6855 marked this pull request as draft April 1, 2023 04:10
@sai6855

This comment was marked as outdated.

@@ -11,6 +11,22 @@ import { expectType } from '@mui/types';
<TextField variant="standard" InputProps={{ classes: { inputTypeSearch: 'search-input' } }} />
);

const StandardInputAdorned = (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests for #36862

@sai6855 sai6855 marked this pull request as ready for review April 17, 2023 09:51
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work well. But I'd like someone else to review before merging, in case I missed anything.

@sai6855 sai6855 requested review from michaldudak and removed request for michaldudak April 28, 2023 09:25
@ZeeshanTamboli ZeeshanTamboli changed the title [TextField] Improve intellisense support for props description [TextField] Improve IntelliSense support for props May 2, 2023
@ZeeshanTamboli
Copy link
Member

Michał didn't find any issues in his review, so it is ready to merge. Looks good to me as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! typescript
Projects
None yet
4 participants