Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slider] Fix ValueLabel UI issues comes when size="small" and orientation="vertical #36738

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

yushanwebdev
Copy link
Contributor

@yushanwebdev yushanwebdev commented Apr 1, 2023

closes #36733

  • Fix the alignment issue
  • Fix the Icon alignment issue
  • Reduce the Gap Between the Label & Slider

Preview: https://codesandbox.io/s/pr-36738-fix-h3vktr

…cal"

- Fix the label alignment issue
- Fix the label's Icon alignment issue
- Reduce the Gap Between the label & Slider
@mui-bot
Copy link

mui-bot commented Apr 1, 2023

Netlify deploy preview

https://deploy-preview-36738--material-ui.netlify.app/

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against 0beccad

@yushanwebdev yushanwebdev changed the title [Slider] Fix label UI issues comes when size="small" and orientation="vertical [Slider] Fix ValueLabel UI issues comes when size="small" and orientation="vertical Apr 1, 2023
@sai6855 sai6855 added the component: slider This is the name of the generic UI component, not the React module! label Apr 3, 2023
@michaldudak
Copy link
Member

It seems to be working well. Thanks for your first PR!

@ZeeshanTamboli ZeeshanTamboli added the bug 🐛 Something doesn't work label Apr 3, 2023
@siriwatknp siriwatknp merged commit 17ca698 into mui:master Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider label is misaligned when size="small" and orientation="vertical"
6 participants