Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Remove upload button #36844

Merged
merged 1 commit into from
May 16, 2023
Merged

Conversation

Bastian
Copy link
Contributor

@Bastian Bastian commented Apr 11, 2023

The upload button example is completely inaccessible by anyone that is not using a mouse. It lacks both support for keyboard interaction and drag-and-drop, as well as not appearing in the accessibility tree.

See #22141 for a more detailed discussion of the problem.

Given these issues, I believe it is irresponsible to promote an inaccessible solution.

@mui-bot
Copy link

mui-bot commented Apr 11, 2023

@Bastian Bastian changed the title Remove upload button from docs [docs] Remove upload button from docs Apr 11, 2023
@Bastian Bastian changed the title [docs] Remove upload button from docs [docs] Remove upload button Apr 11, 2023
The upload button example is completely inaccessible by anyone that is
not using a mouse. It lacks both support for keyboard interaction and
drag-and-drop, as well as not appearing in the accessibility tree.

See mui#22141 for a more detailed
discussion of the issue.
@zannager zannager added docs Improvements or additions to the documentation component: button This is the name of the generic UI component, not the React module! labels Apr 11, 2023
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. Thanks for pointing this out.

@siriwatknp siriwatknp merged commit 1778ef5 into mui:master May 16, 2023
binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: button This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants