Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MenuList] Fix to allow conditional rendering for a menu item under ListSubheader #36890

Merged
merged 2 commits into from
May 30, 2023
Merged

[MenuList] Fix to allow conditional rendering for a menu item under ListSubheader #36890

merged 2 commits into from
May 30, 2023

Conversation

danielplewes
Copy link
Contributor

@danielplewes danielplewes commented Apr 14, 2023 •
edited

Fixes #36889

@mui-bot
Copy link

mui-bot commented Apr 14, 2023 •
edited

Netlify deploy preview

https://deploy-preview-36890--material-ui.netlify.app/

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against 8addd36

@zannager zannager added the component: list This is the name of the generic UI component, not the React module! label Apr 17, 2023
@ZeeshanTamboli ZeeshanTamboli added the regression A bug, but worse label May 30, 2023
@ZeeshanTamboli ZeeshanTamboli changed the title [MenuList] Increment activeItemIndex when set to invalid element [MenuList] Fix conditional rendering under ListSubheader May 30, 2023
@ZeeshanTamboli ZeeshanTamboli changed the title [MenuList] Fix conditional rendering under ListSubheader [MenuList] Fix to allow conditional rendering for a menu item under ListSubheader May 30, 2023
@ZeeshanTamboli ZeeshanTamboli added the bug 🐛 Something doesn't work label May 30, 2023
ZeeshanTamboli
ZeeshanTamboli approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielplewes Thanks for the fix! The logic makes sense.

@ZeeshanTamboli ZeeshanTamboli merged commit d00243f into mui:master May 30, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: list This is the name of the generic UI component, not the React module! regression A bug, but worse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError using conditional rendering under ListSubheader
4 participants
@danielplewes @mui-bot @ZeeshanTamboli @zannager