Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][joy] Add pages for coming soon Joy UI components #36920

Merged
merged 8 commits into from
Jun 16, 2023

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Apr 17, 2023

This PR adds pages for the Drawer and Skeleton components, which have open issues and are therefore marked as comingSoon. These pages help build awareness for their issues, bumping up the number of upvotes and helping us have a tighter grasp of prioritization.

  • Add "integration with headless UI libraries" for both of them, if relevant.

@danilo-leal danilo-leal added docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy labels Apr 17, 2023
@danilo-leal danilo-leal changed the title [docs] Add pages for coming soon components [docs] Add pages for coming soon Joy UI components Apr 17, 2023
@danilo-leal
Copy link
Contributor Author

@siriwatknp just bumping this one up!

@siriwatknp
Copy link
Member

siriwatknp commented Apr 25, 2023

@danilo-leal For the Drawer component, I think we could use the Joy UI Sheet component with CSS variables like in the template

For the Skeleton component, I don't think we need to add "headless integration" section since it is mostly related to CSS.

Anyway, slot this issue on my list. Will find time to work on it.

@danilo-leal danilo-leal changed the title [docs] Add pages for coming soon Joy UI components [docs][joy] Add pages for coming soon Joy UI components May 17, 2023
@danilo-leal danilo-leal added this to the Joy UI: Stable release milestone May 31, 2023
@danilo-leal
Copy link
Contributor Author

@siriwatknp shall we give this one a bump?

@siriwatknp
Copy link
Member

@siriwatknp shall we give this one a bump?

Sorry for the delay, reviewing it.

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊 @danilo-leal I added a minimal version of Drawer and Skeleton to the docs using Joy UI components (there are no headless components for them).

@danilo-leal danilo-leal merged commit 397d0f0 into master Jun 16, 2023
24 checks passed
@danilo-leal danilo-leal deleted the new-component-pages branch June 16, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
Status: Recently completed
Development

Successfully merging this pull request may close these issues.

None yet

3 participants