Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add snackbar example using sonner #36926

Merged
merged 5 commits into from
Apr 23, 2023
Merged

Conversation

PupoSDC
Copy link
Contributor

@PupoSDC PupoSDC commented Apr 18, 2023

Follows up the discussion here: #36603

Adds an example on how to use sonner with joy ui, including how to theme the existing opinionated components to look more like joy ui native components.

@mui-bot
Copy link

mui-bot commented Apr 18, 2023

Netlify deploy preview

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against ec35c9b

@zannager zannager added docs Improvements or additions to the documentation component: snackbar This is the name of the generic UI component, not the React module! labels Apr 19, 2023
Co-authored-by: Siriwat K <siriwatkunaporn@gmail.com>
Signed-off-by: PupoSDC <pupo163@hotmail.com>
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you so much for your contribution! I forked your CodeSandbox to our MUI account so that we can edit them later if there is any change.

docs/data/joy/components/snackbar/snackbar.md Outdated Show resolved Hide resolved
docs/data/joy/components/snackbar/snackbar.md Outdated Show resolved Hide resolved
docs/data/joy/components/snackbar/snackbar.md Outdated Show resolved Hide resolved
Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
@PupoSDC
Copy link
Contributor Author

PupoSDC commented Apr 21, 2023

Is any further worked needed from my side to get this merged?

Let me know! :D

@siriwatknp siriwatknp merged commit 031fb96 into mui:master Apr 23, 2023
@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 4, 2023

@PupoSDC Nice, this demo feels great! It's by far the best on the page IMHO https://mui.com/joy-ui/react-snackbar/, I think that it could/should be at the top of the page.

@oliviertassinari oliviertassinari added the package: joy-ui Specific to @mui/joy label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: snackbar This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants