Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Adjust the Material Icons page design and formatting #36937

Merged
merged 4 commits into from
Apr 20, 2023

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Apr 19, 2023

This PR does some copy/design/formatting adjustments to the Material Icons documentation page. I thought that the content on the current version was too tight, and the callout could be removed for less visual noise. Took advantage of the opportunity to do some light design tweaking as well ⎯ nothing big.

👉 https://deploy-preview-36937--material-ui.netlify.app/material-ui/material-icons/

Before After
Screen Shot 2023-04-19 at 10 24 22 Screen Shot 2023-04-19 at 10 24 19

@danilo-leal danilo-leal added the docs Improvements or additions to the documentation label Apr 19, 2023
The following npm package,
[@mui/icons-material](https://www.npmjs.com/package/@mui/icons-material),
{{"component": "modules/components/ComponentLinkHeader.js"}}
<br/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to add this <br/> element because, for some reason, adding a line here wasn't adding the space 🤔

@mui-bot
Copy link

mui-bot commented Apr 19, 2023

Netlify deploy preview

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 94c568e

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple tiny nitpicky things here.

danilo-leal and others added 2 commits April 20, 2023 19:36
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
@danilo-leal danilo-leal merged commit 690d7d6 into master Apr 20, 2023
11 checks passed
@danilo-leal danilo-leal deleted the icon-page-improvements branch April 20, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants