[Autocomplete] Fixed autocomplete's existing option selection #37012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-37012--material-ui.netlify.app/ Bundle size report |
1 task
zannager
added
the
component: autocomplete
|
This also solves another bug I was going to submit where auto highlight would disappear if items length changes. Can we have this merged please? |
michaldudak
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
This looks good to me! Good job, @bencevoros!
Could you merge in the latest master before we close this to ensure all the tests are run on the current codebase?
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36336
CodeSandbox: https://codesandbox.io/s/mui-autocomplete-bug-fix-2-89beks