Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stepper] Handle progress bar of mobile stepper when steps is one #37079

Merged
merged 10 commits into from
May 30, 2023
Merged

[Stepper] Handle progress bar of mobile stepper when steps is one #37079

merged 10 commits into from
May 30, 2023

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Apr 28, 2023 •
edited

This PR address display inconsistency when steppers steps is being updated between 1 and 2

closes #36134

This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

@gitstart @seunexplicit
Progress Bar Stuck at 0% when Active Step is 0 and Steps Changes From…
16fc1dd 
… 1 to 2 and back to 1

Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
@mui-bot
Copy link

mui-bot commented Apr 28, 2023 •
edited

Netlify deploy preview

https://deploy-preview-37079--material-ui.netlify.app/

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against 30191f9

@gitstart gitstart marked this pull request as ready for review April 28, 2023 13:22
@gitstart
Copy link
Contributor Author

@ZeeshanTamboli this PR is ready for review

@zannager zannager added component: stepper This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels May 1, 2023
@zannager zannager requested a review from hbjORbj May 1, 2023 11:44
ZeeshanTamboli
ZeeshanTamboli requested changes May 4, 2023
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case.

@ZeeshanTamboli ZeeshanTamboli added the PR: needs test The pull request can't be merged label May 4, 2023
@ZeeshanTamboli ZeeshanTamboli changed the title MUI-36134 - [Mobile Stepper] Progress Bar Stuck at 0% when Active Step is 0 and Steps Changes From 1 to 2 and back to 1 [Mobile Stepper] Progress Bar Stuck at 0% when Active Step is 0 and Steps Changes From 1 to 2 and back to 1 May 4, 2023
gitstart and others added 2 commits May 5, 2023 11:31
@gitstart
Merge commit 'b48f0e8fec48461d254f01502f3bb1abd70ed420' of https://gi…
0809ab1 
…thub.com/GitStartHQ/material-ui into MUI-36134
@gitstart @seunexplicit
feat: add implementation test cases
b052882 
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
@gitstart
Copy link
Contributor Author

gitstart commented May 5, 2023

Please add a test case.

Thanks for the feedback @ZeeshanTamboli, I have added a test case for this.

@ZeeshanTamboli ZeeshanTamboli removed the PR: needs test The pull request can't be merged label May 6, 2023
gitstart and others added 2 commits May 10, 2023 08:27
@ZeeshanTamboli ZeeshanTamboli added the bug 🐛 Something doesn't work label May 11, 2023
gitstart and others added 2 commits May 24, 2023 08:23
@gitstart
Merge commit '7c9756bf8a119c2d74ecb3662490ed6d86a699b8' of https://gi…
910fdc4 
…thub.com/GitStartHQ/material-ui into MUI-36134
@gitstart @seunexplicit
implement feedback
e82cff4 
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
ZeeshanTamboli
ZeeshanTamboli reviewed May 24, 2023
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good mostly.

packages/mui-material/src/MobileStepper/MobileStepper.js Outdated Show resolved Hide resolved
packages/mui-material/src/MobileStepper/MobileStepper.test.js Outdated Show resolved Hide resolved
@ZeeshanTamboli ZeeshanTamboli changed the title [Mobile Stepper] Progress Bar Stuck at 0% when Active Step is 0 and Steps Changes From 1 to 2 and back to 1 [Stepper] Handle progress bar of mobile stepper when steps is one May 24, 2023
gitstart and others added 2 commits May 29, 2023 12:22
@gitstart
Merge commit '70d4a2bb49dca9fef7854a1463a392094222812b' of https://gi…
bc93c6e 
…thub.com/GitStartHQ/material-ui into MUI-36134
@gitstart @seunexplicit
implement feedback
89c4b06 
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
@gitstart
Copy link
Contributor Author

@ZeeshanTamboli your comments have been addressed, thanks for the feedback.

@ZeeshanTamboli
Calculate value only for progress variant
30191f9 
Signed-off-by: Zeeshan Tamboli <zeeshan.tamboli@gmail.com>
ZeeshanTamboli
ZeeshanTamboli approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you.

@ZeeshanTamboli ZeeshanTamboli merged commit 63d1d42 into mui:master May 30, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

@hbjORbj hbjORbj Awaiting requested review from hbjORbj

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: stepper This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Mobile Stepper] Progress Bar Stuck at 0% when Active Step is 0 and Steps Changes From 1 to 2 and back to 1
4 participants
@gitstart @mui-bot @ZeeshanTamboli @zannager