-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Popper][base] Drop component prop #37084
Changes from all commits
80c1f3e
df8f15b
0b09986
62339b5
a990728
ecb2979
1644381
9a3a04e
37823c5
c74d98e
0369071
71d32ce
cc9178b
e610d05
c46495a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,6 +21,7 @@ describe('<Popper />', () => { | |
skip: [ | ||
// https://github.com/facebook/react/issues/11565 | ||
'reactTestRenderer', | ||
'componentProp', | ||
], | ||
slots: { | ||
root: { | ||
|
@@ -37,8 +38,7 @@ describe('<Popper />', () => { | |
<Popper | ||
anchorEl={() => document.createElement('div')} | ||
open | ||
component={CustomComponent} | ||
ownerState={{ id: 'id' }} | ||
slots={{ root: CustomComponent }} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am curious, why was the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because external |
||
/>, | ||
); | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This demo will create PropTypes and
![Screenshot 2023-05-01 at 14 47 48](https://user-images.githubusercontent.com/32841130/235460762-6d88ccaf-e258-4bbd-9c99-7d5c62492d76.png)
slotProps.popper
gets wild... here's the snapshot... hence this change for now.. @michaldudakThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's create an issue for this prop, would be great to know what's causing it.