Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Badge][AvatarGroup][joy] js test replaced with ts test #37089

Merged
merged 3 commits into from
May 4, 2023
Merged

[Badge][AvatarGroup][joy] js test replaced with ts test #37089

merged 3 commits into from
May 4, 2023

Conversation

PunitSoniME
Copy link
Contributor

@PunitSoniME PunitSoniME commented Apr 29, 2023 •
edited
Loading

#37078

@PunitSoniME PunitSoniME mentioned this pull request Apr 29, 2023
Closed
62 tasks
@mui-bot
Copy link

mui-bot commented Apr 29, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-37089--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against b26f484

@zannager zannager added component: avatar This is the name of the generic UI component, not the React module! component: badge This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels May 1, 2023
@zannager zannager requested a review from hbjORbj May 1, 2023 11:42
PunitSoniME and others added 3 commits May 3, 2023 18:43
@PunitSoniME
[Badge][AvatarGroup][joy] js test replaced with ts test
c48c050
@PunitSoniME @hbjORbj
Update packages/mui-joy/src/Badge/Badge.test.tsx
1c76cb7 
Co-authored-by: Benny Joo <sldisek783@gmail.com>
Signed-off-by: Punit Soni <punit.soni33@gmail.com>
@PunitSoniME
Update packages/mui-joy/src/AvatarGroup/AvatarGroup.test.tsx
b26f484 
Co-authored-by: Benny Joo <sldisek783@gmail.com>
Signed-off-by: Punit Soni <punit.soni33@gmail.com>

prettier executed

build failed on test cases fixed
@hbjORbj hbjORbj merged commit 028793c into mui:master May 4, 2023
5 checks passed
binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
@PunitSoniME @binh1298
[Badge][AvatarGroup][joy] js test replaced with ts test (mui#37089)
d4eb3a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbjORbj hbjORbj hbjORbj approved these changes

Assignees
No one assigned
Labels
component: avatar This is the name of the generic UI component, not the React module! component: badge This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PunitSoniME @mui-bot @hbjORbj @zannager