Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[List][Menu][joy] Turn JS test to TS test #37123

Merged
merged 3 commits into from
May 3, 2023
Merged

[List][Menu][joy] Turn JS test to TS test #37123

merged 3 commits into from
May 3, 2023

Conversation

uuxxx
Copy link
Contributor

@uuxxx uuxxx commented May 1, 2023 •
edited by mnajdova
Loading

One of #37078

@uuxxx
[List][ListDivider][ListItem][ListItemButton][ListItemContent][ListIt…
493f000 
…emDecorator][Menu][MenuItem][joy] Turn JS test to TS test
@mui-bot
Copy link

mui-bot commented May 1, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-37123--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 462d00e

@uuxxx
Copy link
Contributor Author

uuxxx commented May 1, 2023

#37078

@mnajdova mnajdova added test package: joy-ui Specific to @mui/joy labels May 2, 2023
@mnajdova mnajdova changed the title [List][ListDivider][ListItem][ListItemButton][ListItemContent][ListIemDecorator][Menu][MenuItem][joy] Turn JS test to TS test [List][Menu][joy] Turn JS test to TS test May 2, 2023
mnajdova
mnajdova reviewed May 2, 2023
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, I left few comments

packages/mui-joy/src/MenuItem/MenuItem.test.tsx Outdated Show resolved Hide resolved
packages/mui-joy/src/MenuItem/MenuItem.test.tsx Outdated Show resolved Hide resolved
packages/mui-joy/src/MenuItem/MenuItem.test.tsx Outdated Show resolved Hide resolved
packages/mui-joy/src/MenuItem/MenuItem.test.tsx Outdated Show resolved Hide resolved
packages/mui-joy/src/MenuItem/MenuItem.test.tsx Outdated Show resolved Hide resolved
packages/mui-joy/src/MenuItem/MenuItem.test.tsx Outdated Show resolved Hide resolved
uuxxx and others added 2 commits May 2, 2023 11:42
@uuxxx @mnajdova
Update packages/mui-joy/src/MenuItem/MenuItem.test.tsx
18364d3 
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
Signed-off-by: ux <101122801+uuxxx@users.noreply.github.com>
@mnajdova
fix MenuItem test
462d00e
mnajdova
mnajdova approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@mnajdova mnajdova mentioned this pull request May 2, 2023
Closed
62 tasks
@mnajdova mnajdova merged commit a36e243 into mui:master May 3, 2023
binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
@uuxxx @binh1298
[List][Menu][joy] Turn JS test to TS test (mui#37123)
7a8deda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
package: joy-ui Specific to @mui/joy test typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@uuxxx @mui-bot @mnajdova