[docs][joy] Add adjustments to the color inversion page #37143
Conversation
danilo-leal
added
docs
danilo-leal
changed the title
There was a problem hiding this comment.
Added some copy edits here. I noticed that this page is using the older style of referring to ComponentNames in back ticks so I made suggestions where I noticed them, but we may want to comb through the whole page again to correct any others so it's consistent throughout.
|
@samuelsycamore these look great already, appreciate it! I think we could look back at the Joy docs before its stable launch to refine all of these rough edges 🤙 |
Netlify deploy previewBundle size report |
| @@ -28,14 +27,14 @@ export default function ColorInversionFooter() { | |||
| color={color} | |||
| invertedColors | |||
| sx={{ | |||
| ...(color !== 'warning' && { | |||
| ...(color !== 'neutral' && { | |||
| bgcolor: `${color}.800`, | |||
| }), | |||
| flexGrow: 1, | |||
There was a problem hiding this comment.
@danilo-leal Could we add
…color === 'warning' && {
bgcolor: 'warning.400',
}There was a problem hiding this comment.
Tried locally and it didn't seem to have any effect 😞
There was a problem hiding this comment.
For the sake of alignment: I'll merge this PR as soon as it is approved due to the various copywriting & design tweaks and then we can go back to this issue as it seems something isolated 😬
|
If any of you knows how to help: I've run (Additionally, the first time I ran it, it picked up other files not originally intended to be part of this PR, like Material & Base demos. Not sure why, really...) |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
This PR adds some adjustments to the Joy UI Color inversion page. It includes both some slight copywriting tweaks, as well as information hierarchy and design tweaks (mostly simplifications) to the common examples.
https://deploy-preview-37143--material-ui.netlify.app/joy-ui/main-features/color-inversion/