[Select][base] Keep focus on the trigger element when listbox is open #37244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-37244--material-ui.netlify.app/ @material-ui/unstyled: parsed: -0.57% 😍, gzip: -0.44% 😍 Bundle size report |
|
@michaldudak It is much better! https://codesandbox.io/s/base-cra-ts-forked-1kqn3t?file=/src/App.tsx |
michaldudak
commented
May 12, 2023
| @@ -312,24 +312,12 @@ describe('Joy <Select />', () => { | |||
| expect(getByRole('combobox')).not.to.have.attribute('aria-disabled'); | |||
| }); | |||
|
|
|||
| it('indicates that activating the button displays a listbox', () => { | |||
There was a problem hiding this comment.
According to the ARIA spec, aria-haspopup="listbox" is applied implicitly when role="combobox", so there's no need to add it manually.
| it('renders an element with listbox behavior', () => { | ||
| const { getByRole } = render(<Select defaultListboxOpen value="" />); | ||
|
|
||
| expect(getByRole('listbox')).toBeVisible(); | ||
| }); | ||
|
|
||
| specify('the listbox is automatically focused on open', () => { |
There was a problem hiding this comment.
It's not focused on open anymore to prevent stealing focus from other elements on the page.
michaldudak
added
component: select
binh1298
pushed a commit
to binh1298/material-ui
that referenced
this pull request
May 17, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the focus behavior of the Select. Previously, when Select was expanded, the listbox received focus. Now, the trigger is always focused. This simplifies focus management and prevents stealing focus when the Select is expanded on mount.
Closes #37023