[docs] Improve the Select docs #37279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaldudak
added
docs
Netlify deploy previewBundle size report |
|
|
||
| ### Controlled select | ||
|
|
||
| Select can be used as an uncontrolled or controlled component: |
There was a problem hiding this comment.
As we've learned with feedback in the X docs, we should add a callout here to briefly explain this concept. We could copy the text from this PR: mui/mui-x#8926
| {{"demo": "UnstyledSelectControlled.js", "defaultCodeOpen": false}} | ||
|
|
||
| To set the value of the controlled Select, use the `value` prop. | ||
| In the other case the `defaultValue` can be used to set the initial value of the component. |
There was a problem hiding this comment.
What is meant by "In the other case" here? What is the other case—an uncontrolled Select?
There was a problem hiding this comment.
Yes. I rephrased it a bit.
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com> Signed-off-by: Michał Dudak <michal.dudak@gmail.com>
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
samuelsycamore
approved these changes
Jul 10, 2023
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com> Signed-off-by: Michał Dudak <michal.dudak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few improvements of the Base UI's Select docs.