Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Do not let Renovate handle examples packages updates #37386

Merged

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented May 24, 2023

I noticed renovate opening dependency updates PR for the examples packages to a major version. We eventually close them because we don't want the legacy example material-next-ts-v4-v5-migration, which uses @mui/styles for styling to use the latest versions of Next.js and React (See multiple closed PRs for examples (major)). All examples packages are pinned to the latest versions except material-next-ts-v4-v5-migration.

I propose to altogether remove the config from renovate. Those who are not aware of it could unknowingly merge them.

@ZeeshanTamboli ZeeshanTamboli added dependencies Update of dependencies core Infrastructure work going on behind the scenes labels May 24, 2023
@mui-bot
Copy link

mui-bot commented May 24, 2023

Netlify deploy preview

https://deploy-preview-37386--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 62fc883

@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review May 24, 2023 07:26
@ZeeshanTamboli ZeeshanTamboli requested a review from a team May 24, 2023 07:38
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be more explicit and define:

    {
      "groupName": "examples",
      "matchPaths": ["examples/**/package.json"],
      "enabled": false
    },

Is this equivalent? I haven't tried if this config exist. Is there way to validate if this works somehow?

@ZeeshanTamboli
Copy link
Member Author

ZeeshanTamboli commented May 24, 2023

Should we be more explicit and define:

    {
      "groupName": "examples",
      "matchPaths": ["examples/**/package.json"],
      "enabled": false
    },

Is this equivalent? I haven't tried if this config exist. Is there way to validate if this works somehow?

It's not equivalent. You are correct. We need to be explicit to disable updates by setting enabled: false. Otherwise, it will still open PRs. The default is true. This should work because another example is of node which was done in #30659.

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @ZeeshanTamboli for being proactive to add change this config :)

@ZeeshanTamboli ZeeshanTamboli merged commit 3cab242 into mui:master May 31, 2023
18 checks passed
@ZeeshanTamboli ZeeshanTamboli deleted the examples-renovate-remove-config branch May 31, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes dependencies Update of dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants