-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples] Add Joy UI + Vite.js + TypeScript example app #37406
Merged
ZeeshanTamboli
merged 7 commits into
mui:master
from
nithins1:additional-vite-example-apps
Aug 9, 2023
Merged
[examples] Add Joy UI + Vite.js + TypeScript example app #37406
ZeeshanTamboli
merged 7 commits into
mui:master
from
nithins1:additional-vite-example-apps
Aug 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-37406--material-ui.netlify.app/ Bundle size report |
mnajdova
requested review from
siriwatknp and
samuelsycamore
and removed request for
mnajdova
May 31, 2023 11:33
siriwatknp
reviewed
Jun 2, 2023
siriwatknp
reviewed
Jun 2, 2023
siriwatknp
reviewed
Jun 2, 2023
ZeeshanTamboli
changed the title
[examples] Joy + Vite.js + TypeScript example app
[examples] Add Joy + Vite.js + TypeScript example app
Aug 9, 2023
ZeeshanTamboli
changed the title
[examples] Add Joy + Vite.js + TypeScript example app
[examples] Add Joy UI + Vite.js + TypeScript example app
Aug 9, 2023
ZeeshanTamboli
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nithins1 Thanks for the PR and contribution! I made a few changes and it looks good to go.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps address problems described in #37367 (too many CRA examples, not enough Vite)