[docs] Review fixes to the Material UI's "Example projects" page #37444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-leal
added
docs
Netlify deploy previewhttps://deploy-preview-37444--material-ui.netlify.app/ Bundle size report |
|
@siriwatknp would appreciate if you could give this one a very quick look 😬 |
zanivan
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
@danilo-leal Great, thanks for fixing this.
(I'm cleaning up my list in https://www.notion.so/mui-org/Quick-win-Product-opportunities-408a9771556a4715830d18f3749af753, migrating them to Tasks so it's possible to delegate them)
| @@ -167,7 +157,6 @@ export default function ExampleCollection() { | |||
| href={example.tsLink} | |||
| variant="body2" | |||
| sx={{ | |||
| fontFamily: 'IBM Plex Sans', | |||
| fontWeight: 500, | |||
There was a problem hiding this comment.
It would be better to use theme.typography.fontWeightMedium:
Suggested change
| fontWeight: 500, | |
| fontWeight: 'medium', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on @oliviertassinari's comments at #37007.