Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][joy] Add a rental dashboard template #37453

Merged
merged 45 commits into from
Jun 5, 2023
Merged

[docs][joy] Add a rental dashboard template #37453

merged 45 commits into from
Jun 5, 2023

Conversation

sernstberger
Copy link
Contributor

@sernstberger sernstberger commented May 31, 2023 •
edited

I created a rental dashboard using Joy UI, based on Untitled UI.

https://deploy-preview-37453--material-ui.netlify.app/joy-ui/getting-started/templates/rental-dashboard/

rental-dashboard-dark

rental-dashboard

@sernstberger sernstberger marked this pull request as draft May 31, 2023 12:49
@mui-bot
Copy link

mui-bot commented May 31, 2023 •
edited

Netlify deploy preview

https://deploy-preview-37453--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against e00012f

@mnajdova mnajdova added docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy labels May 31, 2023
danilo-leal
danilo-leal reviewed May 31, 2023
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything here looks super good! Just pushed a small tweak to adjust the Templates collection page. Also, noticed a small scrolling issue where we have two scroll bars making the side navigation scrollable (non-intended, I think) and the image as well!

Screen.Recording.2023-05-31.at.11.06.41.mov

docs/data/joy/getting-started/templates/rental-dashboard/App.tsx Outdated Show resolved Hide resolved
sernstberger and others added 3 commits May 31, 2023 10:12
@sernstberger
comment cleanup
8282860
@sernstberger @danilo-leal
Update docs/data/joy/getting-started/templates/rental-dashboard/App.tsx
1f286fa 
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
Signed-off-by: Steve Ernstberger <steve32285@gmail.com>
@sernstberger
fix component name
b979bc7
@danilo-leal
Copy link
Contributor

@sernstberger just to clarify that I didn't fix the scrolling issue illustrated in the video above 😅
You might want to give it a look!

@sernstberger
Copy link
Contributor Author

@sernstberger just to clarify that I didn't fix the scrolling issue illustrated in the video above 😅 You might want to give it a look!

Oh! I will look at that later today. I'm glad you clarified. Thank you!

@sernstberger
Copy link
Contributor Author

@danilo-leal No more extra scroll bar!

siriwatknp
siriwatknp approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩 Thank you so much! it looks awesome. I have added a button to close the sidebar on small viewports.

@zanivan
Small visual tweaks
b2d14a5 
- Fixed vertical alignment of the star icons
- Removed drop shadow on the active state of cards
- Softened a bit the border radius on the cards
@zanivan
Same map image on desktop an mobile
6989dcb
@zanivan
Copy link
Contributor

zanivan commented Jun 1, 2023

Thanks for the submission, it's wonderfully made! 👏
Just added some small visual tweaks, and noticed that the thumbnails on the template's page are with the old map picture, so it'd be nice to update it afterward.

@sernstberger
Copy link
Contributor Author

@zanivan Thanks! I'm happy to update the images, but would like to wait until all design tweaks are finished.

@sernstberger
Copy link
Contributor Author

Updated screenshots

danilo-leal
danilo-leal approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more tiny tweaks! Aside from those, everything looks great!

docs/data/joy/getting-started/templates/rental-dashboard/App.tsx Outdated Show resolved Hide resolved
docs/data/joy/getting-started/templates/rental-dashboard/components/FirstSidebar.tsx Outdated Show resolved Hide resolved
docs/data/joy/getting-started/templates/rental-dashboard/components/RentalCard.tsx Outdated Show resolved Hide resolved
docs/data/joy/getting-started/templates/rental-dashboard/components/RentalCard.tsx Outdated Show resolved Hide resolved
sernstberger and others added 5 commits June 5, 2023 12:02
@sernstberger @danilo-leal
Update docs/data/joy/getting-started/templates/rental-dashboard/App.tsx
b0216ae 
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
Signed-off-by: Steve Ernstberger <steve32285@gmail.com>
@sernstberger @danilo-leal
Update docs/data/joy/getting-started/templates/rental-dashboard/compo…
6172e70 
…nents/FirstSidebar.tsx

Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
Signed-off-by: Steve Ernstberger <steve32285@gmail.com>
@sernstberger @danilo-leal
Update docs/data/joy/getting-started/templates/rental-dashboard/compo…
df1472a 
…nents/RentalCard.tsx

Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
Signed-off-by: Steve Ernstberger <steve32285@gmail.com>
@sernstberger @danilo-leal
Update docs/data/joy/getting-started/templates/rental-dashboard/compo…
3317543 
…nents/RentalCard.tsx

Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
Signed-off-by: Steve Ernstberger <steve32285@gmail.com>
@sernstberger
new images with design tweaks
e00012f
@sernstberger
Copy link
Contributor Author

Thanks everyone. I merged the design tweaks and added updated screen shots.

@danilo-leal danilo-leal merged commit 8746e36 into mui:master Jun 5, 2023
18 checks passed
@sernstberger sernstberger deleted the rental-dashboard branch June 6, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova left review comments

@siriwatknp siriwatknp siriwatknp approved these changes

@zanivan zanivan zanivan approved these changes

@danilo-leal danilo-leal danilo-leal approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sernstberger @mui-bot @siriwatknp @danilo-leal @zanivan @mnajdova