Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Avatar][Joy] Fallback to alt when src or srcSet are not defined #37469

Merged
merged 5 commits into from
Jun 5, 2023
Merged

[Avatar][Joy] Fallback to alt when src or srcSet are not defined #37469

merged 5 commits into from
Jun 5, 2023

Conversation

vishalthatipamula0219
Copy link
Contributor

@vishalthatipamula0219 vishalthatipamula0219 commented Jun 2, 2023 •
edited by ZeeshanTamboli

Fixes #37459

@vishalthatipamula0219 vishalthatipamula0219 mentioned this pull request Jun 2, 2023
Closed
2 tasks
@mui-bot
Copy link

mui-bot commented Jun 2, 2023 •
edited

Netlify deploy preview

https://deploy-preview-37469--material-ui.netlify.app/

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against 7f92f36

@vishalthatipamula0219 vishalthatipamula0219 marked this pull request as draft June 2, 2023 05:16
@vishalthatipamula0219 vishalthatipamula0219 marked this pull request as ready for review June 2, 2023 06:00
@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work component: avatar This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Jun 2, 2023
@ZeeshanTamboli ZeeshanTamboli changed the title Avatar fix fallback [Avatar][joy] Fallback to alt when src or srcSet are not defined Jun 5, 2023
@ZeeshanTamboli ZeeshanTamboli changed the title [Avatar][joy] Fallback to alt when src or srcSet are not defined [Avatar][Joy] Fallback to alt when src or srcSet are not defined Jun 5, 2023
ZeeshanTamboli
ZeeshanTamboli approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Looking forward for more contributions.

@ZeeshanTamboli ZeeshanTamboli merged commit c2e2008 into mui:master Jun 5, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: avatar This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avatar component should display alt attribute when src or srcSet are empty strings
3 participants
@vishalthatipamula0219 @mui-bot @ZeeshanTamboli