[SvgIcon] Add the new Material Icons #3747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,6 +6,7 @@ | |||
| "main": "./lib", | |||
| "scripts": { | |||
| "build": "babel ./src --out-dir ./lib", | |||
| "build:icon-index-generator": "cd src/svg-icons/ && babel-node index-generator.js", | |||
There was a problem hiding this comment.
Can we change this to just build:icons? Not sure we'll ever need that npm scripts namespace for anything else.
Or, just build:icon-index
nathanmarks
added
PR: needs revision
|
@oliviertassinari I left one or two minor things RE |
Google has made [new releases](https://github.com/google/material-design-icons/releases). - 42 new icons 馃帀 - Upgrade the dependencies - Do some fixes to make the next upgrade smoother. - Use `.js` file extension over `.jsx`
oliviertassinari
added
PR: Needs Review
and removed
PR: needs revision
|
@nathanmarks The package is private. I agree with you, we can remove duplicate dependencies. That should be better now. |
nathanmarks
added a commit
that referenced
this pull request
Mar 22, 2016
[SvgIcon] Add the new Material Icons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google has made new releases.
.jsfile extension over.jsx