Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Link mui-x Stack Overflow in footer link #37509

Merged
merged 11 commits into from
Jun 12, 2023

Conversation

richbustos
Copy link
Contributor

@richbustos richbustos commented Jun 5, 2023

A continuation of https://groups.google.com/a/mui.com/g/devex/c/3R0WQ_fLIE8

Updating Stack Overflow link in the footer:
https://stackoverflow.com/questions/tagged/mui -> https://stackoverflow.com/questions/tagged/mui-x

Questions before committing: This will update the main footer to MUI-X for the Stack Overflow link. Do we want to do this? OR do we only want to update the footer when on https://mui.com/x/?

Preview: https://deploy-preview-37509--material-ui.netlify.app/x/

@richbustos richbustos added the website Pages that are not documentation-related, marketing-focused. label Jun 5, 2023
@oliviertassinari oliviertassinari marked this pull request as draft June 5, 2023 23:21
@oliviertassinari oliviertassinari changed the title [Website] Update Stackoverflow footer link [website] Link mui-x Stack Overflow in footer link Jun 5, 2023
@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 5, 2023

How can I run both at the same time? Do I just run both at different ports?

@richbustos Correct, both are on different ports, so simply yarn docs:dev in both repositories.

And do we have any references of changing the global footer depending on which route we are on?

I think that we can do it like in https://github.com/mui/material-ui/blob/master/docs/pages/x.tsx.

StackOverFlow

-> Stack Overflow

@oliviertassinari oliviertassinari removed their request for review June 5, 2023 23:28
@richbustos
Copy link
Contributor Author

Thanks for the tip, @oliviertassinari. Updated!

@mui-bot
Copy link

mui-bot commented Jun 6, 2023

Netlify deploy preview

https://deploy-preview-37509--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against ca05cf7

@oliviertassinari oliviertassinari marked this pull request as ready for review June 7, 2023 00:51
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richbustos looks good, thanks. This is a small change, but hopefully, it makes sense. Normally, these footer links are company links, but Stack Overflow makes no sense for a company, so I hope it's clear that it's about the given product. I doubt more than 10 people click on this a month 😁. I suspect that we will want to remove the Stack Overflow link from non product pages, like when browsing the blog, it's quite opinionated to point to Material UI Stack Overflow tag.

docs/src/layouts/AppFooter.tsx Outdated Show resolved Hide resolved
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richbustos looks good

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Signed-off-by: Rich Bustos <92274722+richbustos@users.noreply.github.com>
@richbustos
Copy link
Contributor Author

mui
mui x

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richbustos looks good to me. Could you check the error on the test_lint again (at the end of the PR)?

richbustos and others added 2 commits June 8, 2023 13:20
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Signed-off-by: Rich Bustos <92274722+richbustos@users.noreply.github.com>
@richbustos
Copy link
Contributor Author

@richbustos looks good to me. Could you check the error on the test_lint again (at the end of the PR)?

forgot to update the variables elsewhere. committed the fix and hopefully test will pass. Thanks!

@richbustos
Copy link
Contributor Author

@siriwatknp Any idea what this issue is?

Error: Build rejected: upgrade to Pro to use team features.

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 10, 2023

Error: Build rejected: upgrade to Pro to use team features.

@richbustos We had an issue with Argos CI. This is resolved now, rerunning the step in CircleCI solves the issue.

I have pushed one extra commit to better position how this is the company footer rather than the open-source footer. Using the logotype disambiguates the logomark: it's for MUI, not for Material UI.

HEAD

Screenshot 2023-06-10 at 23 09 30

PR

Screenshot 2023-06-10 at 23 13 51

@richbustos richbustos merged commit c10f962 into master Jun 12, 2023
24 checks passed
@richbustos richbustos deleted the update-github-footer branch June 12, 2023 17:08
import * as React from 'react';
import RootSvg, { RootSvgProps } from 'docs/src/icons/RootSvg';

export default function SvgMuiLogomark(props: RootSvgProps) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export default function SvgMuiLogomark(props: RootSvgProps) {
export default function SvgMuiLogotype(props: RootSvgProps) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MUI X website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants