-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Link mui-x Stack Overflow in footer link #37509
Conversation
@richbustos Correct, both are on different ports, so simply
I think that we can do it like in https://github.com/mui/material-ui/blob/master/docs/pages/x.tsx.
-> Stack Overflow |
Thanks for the tip, @oliviertassinari. Updated! |
Netlify deploy previewhttps://deploy-preview-37509--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richbustos looks good, thanks. This is a small change, but hopefully, it makes sense. Normally, these footer links are company links, but Stack Overflow makes no sense for a company, so I hope it's clear that it's about the given product. I doubt more than 10 people click on this a month 😁. I suspect that we will want to remove the Stack Overflow link from non product pages, like when browsing the blog, it's quite opinionated to point to Material UI Stack Overflow tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richbustos looks good
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> Signed-off-by: Rich Bustos <92274722+richbustos@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richbustos looks good to me. Could you check the error on the test_lint
again (at the end of the PR)?
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> Signed-off-by: Rich Bustos <92274722+richbustos@users.noreply.github.com>
…l-ui into update-github-footer
forgot to update the variables elsewhere. committed the fix and hopefully test will pass. Thanks! |
@siriwatknp Any idea what this issue is?
|
04e7f52
to
9f7f699
Compare
@richbustos We had an issue with Argos CI. This is resolved now, rerunning the step in CircleCI solves the issue. I have pushed one extra commit to better position how this is the company footer rather than the open-source footer. Using the logotype disambiguates the logomark: it's for MUI, not for Material UI. HEADPR |
import * as React from 'react'; | ||
import RootSvg, { RootSvgProps } from 'docs/src/icons/RootSvg'; | ||
|
||
export default function SvgMuiLogomark(props: RootSvgProps) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export default function SvgMuiLogomark(props: RootSvgProps) { | |
export default function SvgMuiLogotype(props: RootSvgProps) { |
A continuation of https://groups.google.com/a/mui.com/g/devex/c/3R0WQ_fLIE8
Updating Stack Overflow link in the footer:
https://stackoverflow.com/questions/tagged/mui -> https://stackoverflow.com/questions/tagged/mui-x
Questions before committing: This will update the main footer to MUI-X for the Stack Overflow link. Do we want to do this? OR do we only want to update the footer when on https://mui.com/x/?Preview: https://deploy-preview-37509--material-ui.netlify.app/x/