[docs-infra] Consider files ending with .types.ts as props files #37533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Netlify deploy previewhttps://deploy-preview-37533--material-ui.netlify.app/ Bundle size report |
michaldudak
reviewed
Jun 23, 2023
github-actions
bot
added
PR: out-of-date
|
So, standardizing on |
github-actions
bot
added
the
PR: out-of-date
michaldudak
approved these changes
Jul 20, 2023
I would say yes. We will need to update the Joy UI's file names. cc @siriwatknp After this is done we can update the script again to consider only .types.ts files. |
Signed-off-by: Marija Najdova <mnajdova@gmail.com>
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> Signed-off-by: Marija Najdova <mnajdova@gmail.com>
github-actions
bot
removed
the
PR: out-of-date
richbustos
pushed a commit
that referenced
this pull request
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First reported in #37520. We have currently two conventions for writing types files, .types.ts and Props.ts. This unlocks us for using .types.ts files in @mui/material-next. I noticed that this generated some changes in the Base UI components too, but I would say they are expected. @siriwatknp should we use the same convention in Joy UI too?